Skip to content

Commit

Permalink
Wrap Note in a ScrollView, vastly improve perceived performance
Browse files Browse the repository at this point in the history
  • Loading branch information
@boun
boun committed Feb 25, 2013
1 parent e038c3f commit a047838
Showing 1 changed file with 22 additions and 11 deletions.
33 changes: 22 additions & 11 deletions NotePad/res/layout/note_editor.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,28 @@
android:orientation="vertical"
android:background="@android:color/white"
android:layout_width="fill_parent"
android:layout_height="fill_parent">

<view android:id="@+id/note"
class="org.openintents.notepad.NoteEditor$LinedEditText"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
android:padding="5dip"
android:scrollbars="vertical"
android:fadingEdge="vertical"
android:gravity="top"
android:capitalize="sentences"/>
android:layout_height="match_parent">

<ScrollView
android:id="@+id/scroll"
android:orientation="vertical"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
android:fillViewport="true"
android:fadingEdge="none">
<view android:id="@+id/note"
class="org.openintents.notepad.NoteEditor$LinedEditText"
android:padding="5dip"
android:layout_width="fill_parent"
android:layout_height="fill_parent"
android:background="@color/darkPink"

This comment has been minimized.

Sign in to view

Copy link
@friedger

friedger Mar 3, 2013

Member

The default should not be darkPink but the same color as before. Users should be able to choose their theme.
android:fadingEdge="none"
android:scrollbars="vertical|horizontal"
android:gravity="top"
android:autoText="false"
android:capitalize="none"
/>
</ScrollView>

<LinearLayout android:id="@+id/editor_color"
android:clickable="true"
Expand Down

0 comments on commit a047838

Please sign in to comment.