-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342468: Improve API documentation for java.lang.classfile.constantpool #23046
Conversation
Reviewed-by: asotona
Reviewed-by: jpai, shade
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/issue add 8347163 |
This backport pull request has now been updated with issue from the original commit. |
@liach |
Thanks for the reviews. There was just one unrelated test failure; integrating. /integrate |
Going to push as commit 4a623a2.
Your commit was automatically rebased without conflicts. |
This is a non-clean backport of bcefab5, because afe5434 which fixes a Javadoc link error was also included in this backport. This backports Javadoc improvements to the ClassFile API committed to mainline back to 24, the finalization release of the ClassFile API.
Running tier 1-3 tests right now.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23046/head:pull/23046
$ git checkout pull/23046
Update a local copy of the PR:
$ git checkout pull/23046
$ git pull https://git.openjdk.org/jdk.git pull/23046/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23046
View PR using the GUI difftool:
$ git pr show -t 23046
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23046.diff
Using Webrev
Link to Webrev Comment