8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

[viktorklang-ora]

Seems sensible to improve this given that it can be tricky to figure out which parameter caused the exception to be thrown.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23081/head:pull/23081
$ git checkout pull/23081

Update a local copy of the PR:
$ git checkout pull/23081
$ git pull https://git.openjdk.org/jdk.git pull/23081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23081

View PR using the GUI difftool:
$ git pr show -t 23081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23081.diff

Using Webrev

Link to Webrev Comment

[viktorklang-ora]

@DougLea This is the PR I was talking about earlier today.

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 415 new commits pushed to the master branch:

• 7a0832f: 8349934: Wrong file regex for copyright header format check in .jcheck/conf
• 2a5d1da: 8349571: Remove JavaThreadFactory interface from SA
• 74e458b: 8349684: Remove SA core file tests from problem list for macosx-x64
• ba28119: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
• c5ac3c4: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
• 336d0d8: 8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c
• 4b463ee: 8342103: C2 compiler support for Float16 type and associated scalar operations
• 332d87c: 8349859: Support static JDK in libfontmanager/freetypeScaler.c
• 73e1780: 8349836: G1: Improve group prediction log message
• ed17c55: 8349145: Make Class.getProtectionDomain() non-native
• ... and 405 more: https://git.openjdk.org/jdk/compare/450636ae28b84ded083b6861c6cba85fbf87e16e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7cf05b5b)
• 00: Full (10f59695)

[DougLea]

Thanks for doing this. Looks good to me.

[AlanBateman]

Looks fine, just wondering if the tests for IAE should check there is a message.

[liach]

There's a contributor PR from the java bugs submitter at #23050, I wonder what we should do in this case.

[He-Pin]

#23050

There is already a pr for this:)
As I encountered this in production

And seems the OCA is waiting for processing.

[AlanBateman]

There's a contributor PR from the java bugs submitter at #23050, I wonder what we should do in this case.

The PR has the "oca" label so we can't look or comment on it.

[TheShermanTanker]

There's a contributor PR from the java bugs submitter at #23050, I wonder what we should do in this case.

The PR has the "oca" label so we can't look or comment on it.

:O People from Oracle aren't allowed to look at work from unverified contributors? I learnt something new today

[bridgekeeper]

@viktorklang-ora This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@viktorklang-ora This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.