8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message

[viktorklang-ora]

Seems sensible to improve this given that it can be tricky to figure out which parameter caused the exception to be thrown.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347491: IllegalArgumentationException thrown by ThreadPoolExecutor doesn't have a useful message (Bug - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer) 🔄 Re-review required (review applies to 10f59695)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23081/head:pull/23081
$ git checkout pull/23081

Update a local copy of the PR:
$ git checkout pull/23081
$ git pull https://git.openjdk.org/jdk.git pull/23081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23081

View PR using the GUI difftool:
$ git pr show -t 23081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23081.diff

Using Webrev

Link to Webrev Comment

[viktorklang-ora]

@DougLea This is the PR I was talking about earlier today.

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@viktorklang-ora This change is no longer ready for integration - check the PR body for details.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7cf05b5b)
• 00: Full (10f59695)

[DougLea]

Thanks for doing this. Looks good to me.

[AlanBateman]

Looks fine, just wondering if the tests for IAE should check there is a message.

[liach]

There's a contributor PR from the java bugs submitter at #23050, I wonder what we should do in this case.

[He-Pin]

#23050

There is already a pr for this:)
As I encountered this in production

And seems the OCA is waiting for processing.

[AlanBateman]

There's a contributor PR from the java bugs submitter at #23050, I wonder what we should do in this case.

The PR has the "oca" label so we can't look or comment on it.