Skip to content

8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace #23693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

8311227: Add .editorconfig so IDEs would pick up the common settings automatically: indent, trim trailing whitespace #23693

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02f923e
add editorconfig for better indentation detection
dbriemann Feb 19, 2025
349997a
simplify editorconfig
dbriemann Mar 10, 2025
c0e5ed4
make editorconfig hotspot specific
dbriemann Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,3 @@ root = true

[*]
trim_trailing_whitespace = true

[*.{cpp,hpp,c,h,cc,hh}]
indent_style = space
indent_size = 2

[*.java]
indent_style = space
indent_size = 4
3 changes: 3 additions & 0 deletions src/hotspot/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[*.{cpp,hpp,c,h}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no C files in Hotspot, nor should there ever be. (There are a handful of .h files, though, for interop purposes)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I saw that there are no C files but added it for symmetry with the H files. I don't think it hurts here but I can also remove it. Do you think it should be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is rather up to the Hotspot folks to have an opinion on.

indent_style = space
indent_size = 2