Skip to content

8353581: Support for import module in JShell's code completion #24442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Apr 4, 2025

Adding support for import module to JShell's code completion.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353581: Support for import module in JShell's code completion (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24442/head:pull/24442
$ git checkout pull/24442

Update a local copy of the PR:
$ git checkout pull/24442
$ git pull https://git.openjdk.org/jdk.git pull/24442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24442

View PR using the GUI difftool:
$ git pr show -t 24442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24442.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@lahodaj lahodaj marked this pull request as ready for review April 4, 2025 09:08
@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@lahodaj The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Apr 4, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

@asotona
Copy link
Member

asotona commented Apr 17, 2025

The completion is listed correctly, however it adds(or duplicates) some text to the line.
For example typing "import module java." produces:

jshell> import module java.
java.base             java.compiler         java.datatransfer     java.desktop          java.instrument       java.logging          java.management       java.management.rmi   java.naming           
java.net.http         java.prefs            java.rmi              java.scripting        java.security.jgss    java.security.sasl    java.smartcardio      java.sql              java.sql.rowset       
java.transaction.xa   java.xml              java.xml.crypto       
jshell> import module java.java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kulla kulla-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants