Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8353729: Add unsynchronized variant of ByteArrayOutputStream #24450

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jengebr
Copy link
Contributor

@jengebr jengebr commented Apr 4, 2025

Adds the method ByteArrayOutputStream.unsynchronized, which predictably returns an unsynchronized variant of same. Benchmark (included) shows up to 4x improvement when making many small writes, such as via write(int) or repeated small buffers. No other impacts observed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353729: Add unsynchronized variant of ByteArrayOutputStream (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24450/head:pull/24450
$ git checkout pull/24450

Update a local copy of the PR:
$ git checkout pull/24450
$ git pull https://git.openjdk.org/jdk.git pull/24450/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24450

View PR using the GUI difftool:
$ git pr show -t 24450

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24450.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back jengebr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@jengebr The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant