Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8353486 : Open source Swing Tests - Set 4 #24456

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Apr 4, 2025

Open-sourced the following Swing tests:

  1. javax/swing/JFileChooser/bug4464774.java
  2. javax/swing/JFileChooser/bug4522756.java
  3. javax/swing/JFileChooser/bug4759934.java
  4. javax/swing/JFileChooser/bug4943900.java
  5. javax/swing/JOptionPane/bug4194862.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8353486: Open source Swing Tests - Set 4 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24456/head:pull/24456
$ git checkout pull/24456

Update a local copy of the PR:
$ git checkout pull/24456
$ git pull https://git.openjdk.org/jdk.git pull/24456/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24456

View PR using the GUI difftool:
$ git pr show -t 24456

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24456.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353486: Open source Swing Tests - Set 4

Reviewed-by: dnguyen, tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 356 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 4, 2025
@openjdk
Copy link

openjdk bot commented Apr 4, 2025

@honkar-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Apr 4, 2025

Webrevs

Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I saw via your screenshots on Window how different the rows/cols can appear for the instructions. LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants