8328379: Convert URLDragTest.html applet test to main#3002
8328379: Convert URLDragTest.html applet test to main#3002toshiogata wants to merge 8 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
GHA report 1 test failure on macos-x64
This test failure occurs frequently in recent GHA runs, and is not related to this fix. |
Webrevs
|
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
Keep open. |
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
Keep open. Additional comments for this PR |
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@toshiogata The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@toshiogata The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
@toshiogata This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
Hi all,
I would like to backport this patch to improve test maintainability. The patch is not clean. A text block needs to be replaced with string literals.
Testing: manually checked URLDragTest.java, and confirmed that the test works in the same way.
Thank you.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3002/head:pull/3002$ git checkout pull/3002Update a local copy of the PR:
$ git checkout pull/3002$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3002/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3002View PR using the GUI difftool:
$ git pr show -t 3002Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3002.diff
Using Webrev
Link to Webrev Comment