Skip to content

Comments

8322920: Some ProcessTools.execute* functions are declared to throw Throwable#3025

Closed
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-5fd79e96-master
Closed

8322920: Some ProcessTools.execute* functions are declared to throw Throwable#3025
sendaoYan wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-sendaoYan-5fd79e96-master

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Apr 21, 2025

Hi all,

This pull request contains a backport of commit 5fd79e96 from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 19 Mar 2024 and had no reviewers.

Thanks!


Progress

  • JDK-8322920 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322920: Some ProcessTools.execute* functions are declared to throw Throwable (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3025/head:pull/3025
$ git checkout pull/3025

Update a local copy of the PR:
$ git checkout pull/3025
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3025/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3025

View PR using the GUI difftool:
$ git pr show -t 3025

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3025.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 21, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 21, 2025

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8322920: Some ProcessTools.execute* functions are declared to throw Throwable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 5fd79e961dc370b312e7828a7d1bcc159a0e8635 8322920: Some ProcessTools.execute* functions are declared to throw Throwable Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 21, 2025
@openjdk
Copy link

openjdk bot commented Apr 21, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 21, 2025
@mlbridge
Copy link

mlbridge bot commented Apr 21, 2025

Webrevs

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label May 13, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label May 13, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jun 4, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 4, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2025

@sendaoYan This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jun 16, 2025
@sendaoYan
Copy link
Member Author

/open

@openjdk openjdk bot reopened this Jun 17, 2025
@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@sendaoYan This pull request is now open

@sendaoYan
Copy link
Member Author

/approval request Clean backport to keep the testing tools up to date, and for parity with 11.0.29-oracle. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Jun 17, 2025

@sendaoYan
8322920: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 17, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 15, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented Jul 15, 2025

@sendaoYan The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 8, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approval.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

Going to push as commit 594efb1.
Since your change was applied there have been 35 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2025
@openjdk openjdk bot closed this Aug 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2025
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@sendaoYan Pushed as commit 594efb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant