Skip to content

8343618: Stack smashing in awt_InputMethod.c on Linux s390x #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented May 28, 2025

Backport fixing stack smashing issue in awt_InputMethod.c on s390x. Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8343618 needs maintainer approval

Issue

  • JDK-8343618: Stack smashing in awt_InputMethod.c on Linux s390x (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3037/head:pull/3037
$ git checkout pull/3037

Update a local copy of the PR:
$ git checkout pull/3037
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3037

View PR using the GUI difftool:
$ git pr show -t 3037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3037.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport ee6891456ed672305d9b48846b5a7977373e1284 8343618: Stack smashing in awt_InputMethod.c on Linux s390x May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels May 28, 2025
@openjdk
Copy link

openjdk bot commented May 28, 2025

⚠️ @zzambers This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 28, 2025
@zzambers
Copy link
Contributor Author

/approval request Fix for stack smashing issue in awt_InputMethod.c on s390x. Small change, only affects big endian. Low risk. Clean backport.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@zzambers
8343618: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label May 28, 2025
@mlbridge
Copy link

mlbridge bot commented May 28, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 25, 2025

@zzambers This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant