Skip to content

Comments

8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests#3044

Closed
cost0much wants to merge 1 commit intoopenjdk:masterfrom
cost0much:8315774
Closed

8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests#3044
cost0much wants to merge 1 commit intoopenjdk:masterfrom
cost0much:8315774

Conversation

@cost0much
Copy link
Contributor

@cost0much cost0much commented Jun 6, 2025

Clean backport to make vmTestbase/gc/g1/unloading tests parallel. Passes GHA and vmTestbase/gc/g1/unloading tests.

time make run-test TEST="vmTestbase/gc/g1/unloading
Before:
1220.85s user 109.96s system 53% cpu 41:28.83 total
After:
1240.52s user 89.00s system 707% cpu 3:07.93 total


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315774 needs maintainer approval

Issue

  • JDK-8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3044/head:pull/3044
$ git checkout pull/3044

Update a local copy of the PR:
$ git checkout pull/3044
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3044/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3044

View PR using the GUI difftool:
$ git pr show -t 3044

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3044.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2025

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@cost0much This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 825e0ed2a1fde617ad2a7b74d951df3c1417d463 8315774: Enable parallelism in vmTestbase/gc/g1/unloading tests Jun 6, 2025
@openjdk
Copy link

openjdk bot commented Jun 6, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 6, 2025
@cost0much cost0much marked this pull request as ready for review June 6, 2025 22:16
@openjdk
Copy link

openjdk bot commented Jun 6, 2025

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 6, 2025
@cost0much
Copy link
Contributor Author

/approval request Makes vmTestbase/gc/g1/unloading tests parallel. Clean backport. Passes GHA and vmTestbase/gc/g1/unloading tests. Risk is low: test code only and no change to tests themself.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@cost0much
8315774: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2025

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2025

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cost0much
Copy link
Contributor Author

/keepalive

@openjdk
Copy link

openjdk bot commented Jul 7, 2025

@cost0much The pull request is being re-evaluated and the inactivity timeout has been reset.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2025

@cost0much This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 8, 2025
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2025
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@cost0much
Your change (at version dd2d76c) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

shipilev commented Aug 8, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 8, 2025

Going to push as commit b604657.
Since your change was applied there have been 24 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2025
@openjdk openjdk bot closed this Aug 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 8, 2025
@openjdk
Copy link

openjdk bot commented Aug 8, 2025

@shipilev @cost0much Pushed as commit b604657.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants