Skip to content

8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jun 9, 2025

Hi all,

I am backporting this patch for parity with 11.0.28-oracle release.

This pull request contains a backport of commit 574e1ad7 from the openjdk/jdk17u-dev repository.

The commit being backported was authored by Goetz Lindenmaier on 10 Mar 2025 and had no reviewers.

The initial version of the patch was clean, but I had to update the test to use the old-style switch.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316497 needs maintainer approval

Issue

  • JDK-8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix (Bug - P4 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3046/head:pull/3046
$ git checkout pull/3046

Update a local copy of the PR:
$ git checkout pull/3046
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3046

View PR using the GUI difftool:
$ git pr show -t 3046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3046.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 574e1ad734409bdcf1b78f0c6b53a7196b3b0d66 8316497: ColorConvertOp - typo for non-ICC conversions needs one-line fix Jun 9, 2025
@openjdk
Copy link

openjdk bot commented Jun 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jun 9, 2025
@openjdk openjdk bot removed the clean Identical backport; no merge resolution required label Jun 10, 2025
@mrserb mrserb marked this pull request as ready for review June 10, 2025 02:45
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jun 13, 2025

⚠️ @mrserb This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mrserb
Copy link
Member Author

mrserb commented Jun 25, 2025

/approval request
Backport for parity with 11.0.28-oracle. The patch is mostly clean. The fix is verified by the new test, and no new issues were found by the :jdk_desktop tests.

@openjdk
Copy link

openjdk bot commented Jun 25, 2025

@mrserb
8316497: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants