Skip to content

8355249: Remove the use of WMIC from the entire source code #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurashige23
Copy link
Member

@kurashige23 kurashige23 commented Jul 4, 2025

Hi all,

This is a backport of JDK-8355249 : Remove the use of WMIC from the entire source code

JDK-8355249 is an enhancement, but the future removal of WMIC will affect any version of jdk, so I think it needs to be backported.

Original patch does not apply cleanly because WindowsHelper.java doesn't exist in jdk11. WindowsHelper.java was added in jdk14 (JDK-8212780). Except for this point, original patch applies cleanly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355249 needs maintainer approval

Issue

  • JDK-8355249: Remove the use of WMIC from the entire source code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3057/head:pull/3057
$ git checkout pull/3057

Update a local copy of the PR:
$ git checkout pull/3057
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3057/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3057

View PR using the GUI difftool:
$ git pr show -t 3057

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3057.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2025

👋 Welcome back tkurashige! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 4458719a108f45d3744d47a6ea081fe9ec3e675e 8355249: Remove the use of WMIC from the entire source code Jul 4, 2025
@openjdk
Copy link

openjdk bot commented Jul 4, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 4, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 9, 2025

⚠️ @kurashige23 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants