Skip to content

8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest #3060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Jul 11, 2025

Backporting JDK-8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest. Adjusting test to be compatible with ZGC by slightly shortening output string check. Also cleaning up test by removing redundant "gc=debug". Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8231943 needs maintainer approval

Issue

  • JDK-8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3060/head:pull/3060
$ git checkout pull/3060

Update a local copy of the PR:
$ git checkout pull/3060
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3060

View PR using the GUI difftool:
$ git pr show -t 3060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3060.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport db89b5fdf9f1dca06ba569dbf61e15f637a4367b 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 11, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest

Motivation: Without this change the serviceability/dcmd/gc/RunGCTest test will fail for ZGC. With this backport, the test will pass and increase coverage.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. Change has been present in tip since December, 2019. Only test code for a single test.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@satyenme
8231943: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant