Skip to content

8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected" #3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Jul 11, 2025

Backporting JDK-8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected". Adjusted test to add @ requires for GCs, fixing failure when run with GC directly. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean.


Progress

  • JDK-8247362 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected" (Bug - P3 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3061/head:pull/3061
$ git checkout pull/3061

Update a local copy of the PR:
$ git checkout pull/3061
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3061/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3061

View PR using the GUI difftool:
$ git pr show -t 3061

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3061.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 11, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 74500984585c1b93e91931c19d3b95f86e3085ec 8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected" Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Jul 11, 2025
@openjdk
Copy link

openjdk bot commented Jul 11, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 11, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 11, 2025

Webrevs

@satyenme
Copy link
Author

/approval request for backport of JDK-8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected"

Motivation: Without this change the test/hotspot/jtreg/serviceability/dcmd/gc/HeapDumpCompressedTest.java test will fail when run with jtreg and a GC explicitly set. With this backport, the test coverage will be preserved, and will no longer fail in such scenarios.

Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. Change has been present in tip since June, 2020. Only affects test code for a single test.

@openjdk
Copy link

openjdk bot commented Jul 11, 2025

@satyenme
8247362: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Jul 11, 2025
Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants