-
Notifications
You must be signed in to change notification settings - Fork 240
8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected" #3061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request for backport of JDK-8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected" Motivation: Without this change the Risk: Low. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean. Change has been present in tip since June, 2020. Only affects test code for a single test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Backporting JDK-8247362: HeapDumpCompressedTest.java#id0 fails due to "Multiple garbage collectors selected". Adjusted test to add @ requires for GCs, fixing failure when run with GC directly. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is clean.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3061/head:pull/3061
$ git checkout pull/3061
Update a local copy of the PR:
$ git checkout pull/3061
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3061/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3061
View PR using the GUI difftool:
$ git pr show -t 3061
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3061.diff
Using Webrev
Link to Webrev Comment