Skip to content

8337506: Disable "best-fit" mapping on Windows command line #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kvergizova
Copy link

@kvergizova kvergizova commented Jul 14, 2025

I'd like to backport this for parity with 11.0.29-oracle.
CSR JDK-8349538 has been approved for 11u.
17u patch applies cleanly, but the test requires a few modifications to work properly:

The new test passes successfully after applying the patch.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337506 needs maintainer approval
  • Change requires CSR request JDK-8349538 to be approved

Issues

  • JDK-8337506: Disable "best-fit" mapping on Windows command line (Bug - P4)
  • JDK-8349538: Disable "best-fit" mapping on Windows command line (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3062/head:pull/3062
$ git checkout pull/3062

Update a local copy of the PR:
$ git checkout pull/3062
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3062/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3062

View PR using the GUI difftool:
$ git pr show -t 3062

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3062.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 14, 2025

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 94f8a744e03d7cbe6527e35b0df6ffc33c29ff06 8337506: Disable "best-fit" mapping on Windows command line Jul 14, 2025
@openjdk
Copy link

openjdk bot commented Jul 14, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 14, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant