Skip to content

8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satyenme
Copy link

@satyenme satyenme commented Jul 16, 2025

Backporting JDK-8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs. Adjusting test to be compatible with GCs other than G1. Ran GHA Sanity Checks, local Tier 1 and 2, and adjusted test directly. Patch is nearly clean: since Reference.refersTo is not supported, needs minor adjustments.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8283276 needs maintainer approval

Issue

  • JDK-8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3064/head:pull/3064
$ git checkout pull/3064

Update a local copy of the PR:
$ git checkout pull/3064
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3064/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3064

View PR using the GUI difftool:
$ git pr show -t 3064

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3064.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 16, 2025

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d4a795d75aef8d787934f5c05e146c61138a408a 8283276: java/io/ObjectStreamClass/ObjectStreamClassCaching.java fails with various GCs Jul 16, 2025
@openjdk
Copy link

openjdk bot commented Jul 16, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Jul 16, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 16, 2025

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport from 17u net of deleted line formatting.

@openjdk
Copy link

openjdk bot commented Jul 16, 2025

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@satyenme
Copy link
Author

Taking a closer look at the history, seeing this commit when initially backporting the test. Planning to adjust to not use Reference.refersTo (which JDK 11 doesn't directly support), rerun local tests and add another commit here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants