-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348606: [lworld] Substitutability test may perform heap allocations #1364
base: lworld
Are you sure you want to change the base?
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change is no longer ready for integration - check the PR body for details. |
Webrevs
|
The reason you are seeing the failures is that you are using
The wording here is albeit bad, it is not only the result that is undefined, the behaviour itself is undefined. |
Hmm, @fparain recommends this access pattern for me... |
…/vo-obj-getters
Update substitutability test to use MethodHandles that access independent primitive/pointer instead heap reallocated copies of inlined values with an object header. Need long-term solution for user MethodHandle that accesses nested values in the future; hope the intrinsics can help in the future.
Testing: test/jdk/valhalla and test/hotspot/jtreg/*/valhalla, tier 1-3 tests running.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1364/head:pull/1364
$ git checkout pull/1364
Update a local copy of the PR:
$ git checkout pull/1364
$ git pull https://git.openjdk.org/valhalla.git pull/1364/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1364
View PR using the GUI difftool:
$ git pr show -t 1364
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1364.diff
Using Webrev
Link to Webrev Comment