8373930: [lworld] Restore Objects.equals use of identity check

[RogerRiggs]

Revert "8366841: [lworld] Objects.equals without identity comparison". (Almost all)
Removing the condition on --enable-preview.
Correct the .equals method in test SimplValueGraphs.SimpleValue.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

• JDK-8373930: [lworld] Restore Objects.equals use of identity check (Bug - P4)

Reviewers

• Chen Liang (@liach - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1836/head:pull/1836
$ git checkout pull/1836

Update a local copy of the PR:
$ git checkout pull/1836
$ git pull https://git.openjdk.org/valhalla.git pull/1836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1836

View PR using the GUI difftool:
$ git pr show -t 1836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1836.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8373930: [lworld] Restore Objects.equals use of identity check

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 132 new commits pushed to the lworld branch:

• be451e1: 8374947: [lworld] ProblemList serviceability/sa/ClhsdbTestAllocationMerge.java in Xcomp mode
• f6c9928: 8374810: [lworld] Generate COH archives
• 1ecc74b: 8374887: [lworld] Cleanup around vgetfield/vputfield for x86
• ... and 129 more: https://git.openjdk.org/valhalla/compare/e98a14938b735d282c4335c67e2cd2201029b900...lworld

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (2cea111f)
• 00: Full (9aa1f037)

[RogerRiggs]

If you are looking for something easy to get started in the new year, consider reviewing this backout restoring Object.equals to its previous implementation.

[RogerRiggs]

/touch

[openjdk]

@RogerRiggs The pull request is being re-evaluated and the inactivity timeout has been reset.