Skip to content

Conversation

@marc-chevalier
Copy link
Member

@marc-chevalier marc-chevalier commented Jan 12, 2026

Backout JDK-8371388 was done in commit 48bbc95
which arrived in Valhalla in Merge jdk #1772, that was merged on the 8th Dec. Tested with
tier1,tier2,tier3,hs-precheckin-comp,hs-comp-stress,valhalla-comp-stress, and I obersed no failure of TestVerifyGraphEdges.java,
while it should have been enough to observe multiple failures before.

It seems fine to unproblem list then!

Thanks,
Marc


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8372723: [lworld] Un-problem list TestVerifyGraphEdges.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1885/head:pull/1885
$ git checkout pull/1885

Update a local copy of the PR:
$ git checkout pull/1885
$ git pull https://git.openjdk.org/valhalla.git pull/1885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1885

View PR using the GUI difftool:
$ git pr show -t 1885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1885.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2026

👋 Welcome back mchevalier! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2026

@marc-chevalier This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372723: [lworld] Un-problem list TestVerifyGraphEdges.java

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the lworld branch:

  • ab311a7: 8374913: [lworld] UnProblemList three tests due to JDK-8372341
  • 13abe7d: 8374165: [lworld] Shortcut in value copying can lead to incorrect substitutability tests
  • 093d033: 8374554: [lworld] Field layout assert with UseCompactObjectHeaders

Please see this link for an up-to-date comparison between the source branch of this pull request and the lworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@marc-chevalier marc-chevalier marked this pull request as ready for review January 12, 2026 13:31
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 12, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2026

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this Marc! Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants