Skip to content

Conversation

@vicente-romero-oracle
Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Jan 12, 2026

fixing regression tests related to signatures with null restricted elements


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1887/head:pull/1887
$ git checkout pull/1887

Update a local copy of the PR:
$ git checkout pull/1887
$ git pull https://git.openjdk.org/valhalla.git pull/1887/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1887

View PR using the GUI difftool:
$ git pr show -t 1887

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1887.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2026

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into bworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 12, 2026

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Fix nullability signature attr tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the bworld branch:

  • b0e093b: generate null checks for intersections for which at least one component is null restricted

Please see this link for an up-to-date comparison between the source branch of this pull request and the bworld branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the bworld branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 12, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant