-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Satisfiability.jl: Satisfiability Modulo Theories in Julia #6757
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
|
Review checklist for @rafaelbailoConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @computableeConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @rafaelbailo, @dpsanders, @computablee how is your review going? |
@diehlpk I was just taking a look at this a couple days ago. Things have been very busy with work, but if all goes well I should be able to get a lot of review stuff done this weekend. |
Hi @diehlpk, I've just posted my review in a separate issue. Thanks for your patience! |
Hi @rafaelbailo how is your review going? |
Hi @diehlpk, @elsoroka has began work addressing my comments in the review issue. |
Hi @elsoroka please let me know when you have done the changes. |
Hi @diehlpk apologies for the delay; I started a new internship a couple weeks ago and haven't had much time. I am targeting end of this week to make the changes because we have a couple days off for the holiday. |
Review checklist for @dpsandersConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Apologies for the delay in my review. Here are some observations. This is a very nice package, providing key functionality for the Julia ecosystem. The documentation is very well done, with nice motivating examples.
Overall this is a very nice piece of work! |
@editorialbot generate pdf |
Hi @diehlpk, all my queries have been satisfied, and I've ticked all the items on my checklist. As far as I'm concerned, the paper is good to go 👍🏻 . |
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5781, then you can now move forward with accepting the submission by compiling again with the command |
As track editor, I'll next proofread this and provide further instructions, if any are needed, probably in the next 12 or so hours. |
@elsoroka - I just found 2 small changes needed in the references, as indicated in elsoroka/Satisfiability.jl#66 Please merge this, or let me now what you disagree with, then we can finish the publication process. |
@danielskatz Thank you for catching that! I merged it in |
@editorialbot recommend-accept generating new proof - will check again and hopefully complete in a couple of hours... |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5784, then you can now move forward with accepting the submission by compiling again with the command |
👋 @elsoroka - the changes I made in the PR didn't make it in to this proof, I think because I was working in your main branch but this review thread is working in joss-paper. Should JOSS be working in main now? If so, we can change this thread to point to main. If not, can you make the same two changes in the joss-paper branch? |
Hi @danielskatz - to solve this, I merged the changes from main into joss-paper. So now the two branches should be in sync elsoroka/Satisfiability.jl@main...joss-paper. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/csism-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5786, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to the authors, and thank you everyone for your hard work! 🎉🎊 |
Congratulations on the publication! |
Congratulations to @elsoroka (Emiko Soroka) and co-authors on your publication!! And thanks to @rafaelbailo, @dpsanders, and @computablee for reviewing, and to @diehlpk for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you everyone for your help reviewing and editing and congratulations to co-authors @mykelk and @sanjaylall! |
Congratulations to the authors for their nice work and paper! |
Submitting author: @elsoroka (Emiko Soroka)
Repository: https://github.com/elsoroka/Satisfiability.jl
Branch with paper.md (empty if default branch): joss-paper
Version: 0.2.0
Editor: @diehlpk
Reviewers: @rafaelbailo, @dpsanders, @computablee
Archive: 10.6084/m9.figshare.26768461
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@rafaelbailo & @dpsanders & @computablee, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @rafaelbailo
📝 Checklist for @computablee
📝 Checklist for @dpsanders
The text was updated successfully, but these errors were encountered: