[release-0.4] bugfix: Filter rs that are not part of the current Deployment #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvlisn
force-pushed
the
backport-191-to-0.4
branch
3 times, most recently
from
a430bf9 to
22f6543
Compare
…ot part of the current Deployement) Signed-off-by: vvhuang-ll <[email protected]>
vvlisn
force-pushed
the
backport-191-to-0.4
branch
3 times, most recently
from
cca34e9 to
eae1b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This is a backport of the fix from PR #191 to the
release-0.4branch.#191
Ⅱ. Does this pull request fix one issue?
In the
release-0.4version, the issue occurs when the Deployment controller fails to filter ReplicaSets (rs) that are not part of the current Deployment. This can lead to incorrect behavior and potential conflicts in the Deployment process.Ⅲ. Special notes for reviews
The fix has been adjusted to be compatible with the
release-0.4branch. The changes are minimal and do not introduce any new dependencies or breaking changes.