Skip to content

Conversation

@GautamBytes
Copy link
Contributor

Ⅰ. Describe what this PR does

  • Extends the classType enum in the CRD to include aws-alb.

  • Updates the Go API types’ documentation to mention aws-alb.

  • Adds a new lua_configuration/trafficrouting_ingress/aws-alb.lua script that builds a weighted forward action with both stable and canary target groups, plus optional header/cookie/sourceIP conditions.

  • Modifies the controller to pass both StableService and CanaryService into the Lua context.

  • Extends unit tests (ingress_test.go) to load the new Lua script and validates the AWS‑ALB annotations JSON.

Ⅱ. Does this pull request fix one issue?

fixes #129

Ⅲ. Special notes for reviews

Verify that the Lua script produces valid AWS ALB Controller annotations.

@kruise-bot kruise-bot requested review from FillZpp and veophi June 28, 2025 15:31
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: GautamBytes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

支持aws alb ingress 灰度

2 participants