feat: implement config service retreaving service providers data #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-oetzel
requested changes
Aug 9, 2024
|
|
||
| getInitialStaticSettingsConfig() { | ||
| const blankImg = 'data:image/gif;base64,R0lGODlhAQABAAAAACwAAAAAAQABAAAC'; | ||
| const logo = this.luigiCoreService.isFeatureToggleActive('mfp-logo') |
There was a problem hiding this comment.
i think we should only use the mfp logo in the ui-lib.
Also the assets of ora should be deleted. We should keep all the openmfp parts ora free
src/assets/ora-logo.svg
Outdated
src/assets/ora-mark.svg
Outdated
src/lib/model/portal-config.ts
Outdated
| export interface PortalConfig { | ||
| providers: ServiceProvider[]; | ||
| tenantId: string; | ||
| frameContext: Record<string, any>; |
There was a problem hiding this comment.
yes, I have that in my todo list it has to be done in few places at the same time, it's still as well in the portal-server-lib
| ); | ||
| }); | ||
|
|
||
| it('should return the correct configuration with ORA logo when feature toggle is inactive', () => { |
There was a problem hiding this comment.
as stated below - remove me
…fig-service # Conflicts: # src/lib/services/luigi-config/luigi-config.service.ts
tobias-oetzel
approved these changes
Aug 12, 2024
* feat: luigi nodes service implementation
renovate bot
added a commit
that referenced
this pull request
Dec 28, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cpx2](https://redirect.github.com/bcomnes/cpx2) | [`^2.0.0` -> `^8.0.0`](https://renovatebot.com/diffs/npm/cpx2/2.0.0/8.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bcomnes/cpx2 (cpx2)</summary> ### [`v8.0.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v800) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v7.0.2...v8.0.0) ##### Commits - **Breaking change:** Update engines field to node 20 [`f17186a`](https://redirect.github.com/bcomnes/cpx2/commit/f17186af668d775765dfbaf5929b54901d7b84ee) - Merge pull request [#​125](https://redirect.github.com/bcomnes/cpx2/issues/125) from bcomnes/deps [`edb319e`](https://redirect.github.com/bcomnes/cpx2/commit/edb319e0258c50455bbd1c1f0e1caff069f0edeb) - Update p-map and double check installed-check [`af2efce`](https://redirect.github.com/bcomnes/cpx2/commit/af2efcef86b62e7ebf81774ad09a1ea3ba13b26e) ### [`v7.0.2`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v702---2024-10-04) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v7.0.1...v7.0.2) ##### Merged - Upgrade: Bump glob from 10.4.4 to 11.0.0 [`#119`](https://redirect.github.com/bcomnes/cpx2/pull/119) - Upgrade: Bump minimatch from 9.0.5 to 10.0.1 [`#118`](https://redirect.github.com/bcomnes/cpx2/pull/118) - Upgrade: Bump nyc from 15.1.0 to 17.0.0 [`#117`](https://redirect.github.com/bcomnes/cpx2/pull/117) ##### Fixed - Set allowRelativePaths for apply acitons [`#113`](https://redirect.github.com/bcomnes/cpx2/issues/113) ##### Commits - Merge pull request [#​124](https://redirect.github.com/bcomnes/cpx2/issues/124) from bcomnes/fix-relative-copy-errors [`e35a68a`](https://redirect.github.com/bcomnes/cpx2/commit/e35a68ad3c268a6a8ea1ae2e3c17c89264251844) - Merge pull request [#​123](https://redirect.github.com/bcomnes/cpx2/issues/123) from bcomnes/neostandard [`ab10190`](https://redirect.github.com/bcomnes/cpx2/commit/ab10190b16e7c00c212812b3d7b1ada514274359) - Autofix [`1396a28`](https://redirect.github.com/bcomnes/cpx2/commit/1396a28cf26903aa1f4796c3f9d902a3dff32241) ### [`v7.0.1`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v701---2023-12-29) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v7.0.0...v7.0.1) ##### Commits - fix: minimum node version down to 18 [`05a55cc`](https://redirect.github.com/bcomnes/cpx2/commit/05a55cc2907b49197a64bc576ee15ea83a76ff92) ### [`v7.0.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v700---2023-12-25) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v6.0.1...v7.0.0) ##### Commits - Remove files filter [`e9ef541`](https://redirect.github.com/bcomnes/cpx2/commit/e9ef541d5c2e0ca8fb5614a470def89443515532) - Bump minimum node version to lts 20 [`56bbc19`](https://redirect.github.com/bcomnes/cpx2/commit/56bbc19f9d5f50037ad222792d323920677836e9) - Upgrade: Bump debounce from 1.2.1 to 2.0.0 [`390cd9d`](https://redirect.github.com/bcomnes/cpx2/commit/390cd9dda1a57d6d775d1b93bd379ffc4c1f9b43) ### [`v6.0.1`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v601---2023-10-25) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v6.0.0...v6.0.1) ##### Merged - Upgrade: Bump actions/setup-node from 3 to 4 [`#111`](https://redirect.github.com/bcomnes/cpx2/pull/111) ##### Commits - Fix windows bugs with new glob [`eb7ab6a`](https://redirect.github.com/bcomnes/cpx2/commit/eb7ab6a881cd1259fa2d43423837b4428747f397) - Add more OSs to tests [`35128d8`](https://redirect.github.com/bcomnes/cpx2/commit/35128d81b7e625ddfd73fbd2695e1ea01fab53c5) ### [`v6.0.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v600---2023-10-22) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v5.0.0...v6.0.0) ##### Merged - Update to the latest glob [`#110`](https://redirect.github.com/bcomnes/cpx2/pull/110) - Upgrade: Bump actions/checkout from 3 to 4 [`#109`](https://redirect.github.com/bcomnes/cpx2/pull/109) ##### Commits - Update test.yml [`f93bad5`](https://redirect.github.com/bcomnes/cpx2/commit/f93bad5f774f71185e97286b697ef88815d64433) - Fix import [`f03ed57`](https://redirect.github.com/bcomnes/cpx2/commit/f03ed5740ca0eb52a1ad409a09ecfc965f7651d1) - Fix CI versions [`65f2e64`](https://redirect.github.com/bcomnes/cpx2/commit/65f2e64595f8c8162198c05cda9901f66ab79acd) ### [`v5.0.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v500---2023-07-05) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.2.3...v5.0.0) ##### Merged - Upgrade: Bump minimatch from 8.0.4 to 9.0.0 [`#107`](https://redirect.github.com/bcomnes/cpx2/pull/107) ##### Commits - Update deps and require >= node 16 [`1862ff6`](https://redirect.github.com/bcomnes/cpx2/commit/1862ff62d0d1db57f1230a4df84b9ccd1e8a63be) - Fix imports [`e1b5778`](https://redirect.github.com/bcomnes/cpx2/commit/e1b577837014de19a613a02ea438f53d3b76892e) ### [`v4.2.3`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v423---2023-04-03) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.2.2...v4.2.3) ##### Merged - Upgrade: Bump minimatch from 7.4.4 to 8.0.2 [`#106`](https://redirect.github.com/bcomnes/cpx2/pull/106) ### [`v4.2.2`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v422---2023-03-07) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.2.1...v4.2.2) ##### Merged - Upgrade: Bump mocha from 9.2.2 to 10.2.0 [`#79`](https://redirect.github.com/bcomnes/cpx2/pull/79) ### [`v4.2.1`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v421---2023-03-07) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.2.0...v4.2.1) ##### Merged - Deps [`#105`](https://redirect.github.com/bcomnes/cpx2/pull/105) ##### Commits - Update actions [`ffb450b`](https://redirect.github.com/bcomnes/cpx2/commit/ffb450b88d71b7f2bab1a935c6725814b0f076c5) - Remove rimraf [`45c5991`](https://redirect.github.com/bcomnes/cpx2/commit/45c59919a8af37f37aa54f56326480de5c6c441e) - Update shell quote [`4f20279`](https://redirect.github.com/bcomnes/cpx2/commit/4f20279e5cf9010d661119e5f86cfa196efb8fcd) ### [`v4.2.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v420---2022-02-08) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.1.2...v4.2.0) ##### Merged - Fix [#​53](https://redirect.github.com/bcomnes/cpx2/issues/53): Overwrite readonly [`#57`](https://redirect.github.com/bcomnes/cpx2/pull/57) - Upgrade: Bump actions/setup-node from 2.5.0 to 2.5.1 [`#52`](https://redirect.github.com/bcomnes/cpx2/pull/52) ##### Fixed - Merge pull request [#​57](https://redirect.github.com/bcomnes/cpx2/issues/57) from schutm/overwrite-readonly [`#53`](https://redirect.github.com/bcomnes/cpx2/issues/53) ##### Commits - Add force flag to overwrite readonly files [`e622923`](https://redirect.github.com/bcomnes/cpx2/commit/e622923a4ab495571482958d77ddd0aa7a9a5243) - Eat exception if target doesn't exist [`f7c1fb3`](https://redirect.github.com/bcomnes/cpx2/commit/f7c1fb3ddbd3a57b4f18c4b117dc5f9bd28eeea1) - Pin to major actions version [`94a5f34`](https://redirect.github.com/bcomnes/cpx2/commit/94a5f347bbb5d0e53a2d8156b390f634e5a543ae) ### [`v4.1.2`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v412---2021-12-23) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.1.1...v4.1.2) ##### Merged - Allow watching from a relative directory again [`#51`](https://redirect.github.com/bcomnes/cpx2/pull/51) ##### Fixed - Allow watching from a relative directory again [`#44`](https://redirect.github.com/bcomnes/cpx2/issues/44) ### [`v4.1.1`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v411---2021-12-22) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.1.0...v4.1.1) ##### Merged - Remove co [`#50`](https://redirect.github.com/bcomnes/cpx2/pull/50) ##### Commits - Remove co from watch tests [`f296a6b`](https://redirect.github.com/bcomnes/cpx2/commit/f296a6baa040868c2cb59b09aa520cd6a6bc8ada) - Remove co in watcher [`7191ee9`](https://redirect.github.com/bcomnes/cpx2/commit/7191ee967dd760ac64d629e12bb561d8fd6ff3e0) - Remove co from copy tests [`1f72f04`](https://redirect.github.com/bcomnes/cpx2/commit/1f72f04e9845f8957a5011ef83a5b0bdbdc51443) ### [`v4.1.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v410---2021-12-22) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v4.0.0...v4.1.0) ##### Merged - Upgrade: Bump actions/checkout from 2.3.4 to 2.4.0 [`#39`](https://redirect.github.com/bcomnes/cpx2/pull/39) - Upgrade: Bump actions/setup-node from 2.4.0 to 2.5.0 [`#45`](https://redirect.github.com/bcomnes/cpx2/pull/45) - Return a report object containing details about the copy operation [`#49`](https://redirect.github.com/bcomnes/cpx2/pull/49) ### [`v4.0.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v400---2021-09-15) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v3.0.2...v4.0.0) ##### Merged - Add gitignore style ignore support [`#32`](https://redirect.github.com/bcomnes/cpx2/pull/32) ##### Commits - **Breaking change:** Require node >=14 [`074e5b5`](https://redirect.github.com/bcomnes/cpx2/commit/074e5b5d338cf57df2cb0e02ec654e3b5c3e080f) - Add ignore option and flag [`be9680c`](https://redirect.github.com/bcomnes/cpx2/commit/be9680c7e8e84ebb1b43c089d53d9b6e3bbf4a4b) ### [`v3.0.2`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v302---2021-08-13) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v3.0.1...v3.0.2) ##### Commits - Revert "Merge pull request [#​23](https://redirect.github.com/bcomnes/cpx2/issues/23) from mhanberg/mh/exit-on-stdin-closing" [`d1275a0`](https://redirect.github.com/bcomnes/cpx2/commit/d1275a0f6d26e3084deaa3b4d20b7d8524c6719d) ### [`v3.0.1`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v301---2021-08-09) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v3.0.0...v3.0.1) ##### Merged - Upgrade: Bump actions/setup-node from 2.3.2 to 2.4.0 [`#31`](https://redirect.github.com/bcomnes/cpx2/pull/31) - Exit when stdin closes [`#23`](https://redirect.github.com/bcomnes/cpx2/pull/23) - Upgrade: Bump fs-extra from 9.1.0 to 10.0.0 [`#17`](https://redirect.github.com/bcomnes/cpx2/pull/17) - Upgrade: Bump gh-release from 4.0.4 to 6.0.0 [`#20`](https://redirect.github.com/bcomnes/cpx2/pull/20) - Upgrade: Bump mocha from 8.4.0 to 9.0.3 [`#28`](https://redirect.github.com/bcomnes/cpx2/pull/28) - Upgrade: Bump actions/setup-node from 2.1.2 to 2.3.2 [`#30`](https://redirect.github.com/bcomnes/cpx2/pull/30) - Upgrade: Bump actions/checkout from v2.3.3 to v2.3.4 [`#11`](https://redirect.github.com/bcomnes/cpx2/pull/11) - Upgrade: Bump bcomnes/npm-bump from v2.0.1 to v2.0.2 [`#10`](https://redirect.github.com/bcomnes/cpx2/pull/10) - Upgrade: Bump actions/setup-node from v2.1.1 to v2.1.2 [`#9`](https://redirect.github.com/bcomnes/cpx2/pull/9) - Upgrade: Bump actions/checkout from v2.3.2 to v2.3.3 [`#8`](https://redirect.github.com/bcomnes/cpx2/pull/8) ##### Commits - Lint [`9db062f`](https://redirect.github.com/bcomnes/cpx2/commit/9db062f4e5131540b3a39ae58860a49b2fdf191a) ### [`v3.0.0`](https://redirect.github.com/bcomnes/cpx2/blob/HEAD/CHANGELOG.md#v300---2020-09-18) [Compare Source](https://redirect.github.com/bcomnes/cpx2/compare/v2.0.0...v3.0.0) ##### Merged - Upgrade: Bump [@​mysticatea/eslint-plugin](https://redirect.github.com/mysticatea/eslint-plugin) from 11.0.0 to 13.0.0 [`#4`](https://redirect.github.com/bcomnes/cpx2/pull/4) - Upgrade: Bump nyc from 14.1.1 to 15.1.0 [`#5`](https://redirect.github.com/bcomnes/cpx2/pull/5) - Upgrade: Bump eslint from 6.8.0 to 7.9.0 [`#6`](https://redirect.github.com/bcomnes/cpx2/pull/6) - Upgrade: Bump fs-extra from 8.1.0 to 9.0.1 [`#7`](https://redirect.github.com/bcomnes/cpx2/pull/7) - Upgrade: Bump mocha from 6.2.3 to 8.1.3 [`#3`](https://redirect.github.com/bcomnes/cpx2/pull/3) - try building windows [`#2`](https://redirect.github.com/bcomnes/cpx2/pull/2) ##### Commits - switch to github actions and dependabot [`9eaf5e0`](https://redirect.github.com/bcomnes/cpx2/commit/9eaf5e0e37d57e197cdc607a6c79148c4d9428a6) - Add release action [`399f37f`](https://redirect.github.com/bcomnes/cpx2/commit/399f37f8b06f66623278d24713f28a321bdf4ee4) - Fix lint errors [`8e96f93`](https://redirect.github.com/bcomnes/cpx2/commit/8e96f93631b250121ec4c570474d96a3d362d542) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/openmfp/portal-ui-lib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS44MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement config service retreaving service providers data