Skip to content

Conversation

@Timug-123
Copy link

Description of what I changed

TRUNK-5782: Concept Domain - Switching from Hibernate Mappings to Annotations

Issue I worked on

I have changed from XML mapping to JPA annotations for the required fields in the concept Domain!
There some 2 tests that failed to run because of manually assigning IDs. Please see the pastebin link with the errors https://pastebin.com/jiWCrQGd and https://pastebin.com/vgihpy1Q

see https://openmrs.atlassian.net/browse/TRUNK-5782

Checklist: I completed these to help reviewers :)

  • My IDE is configured to follow the code style of this project.

    No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)

    No? -> write tests and add them to this commit git add . && git commit --amend

  • I ran mvn clean package right before creating this pull request and
    added all formatting changes to my commit.

    No? -> execute above command

  • All new and existing tests passed.

    No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@Timug-123
Copy link
Author

@dkayiwa kindly help me review this pr with the updated changes.

@dkayiwa
Copy link
Member

dkayiwa commented Oct 21, 2025

@Timug-123 did you see the above build failure?

@Timug-123
Copy link
Author

@dkayiwa kindly help me review this pr with the updated changes.

@Timug-123 did you see the above build failure?

@dkayiwa I have looked at the error and I have used the (fetch = FetchType.LAZY) but still getting the same error after an mvn clean install. The other alternative is making some adjustments in those failing tests. kindly advise on what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants