Skip to content

(feat) Add label printing app for handling printing concerns #2433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

jnsereko
Copy link
Contributor

@jnsereko jnsereko commented May 8, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Previous versions of the Patient Identifier Sticker used react libraries to capture and print the sticker. Since this became slow on low processor powered devices, this approach focuses on getting the sticker from the backend using the Reporting tooling.
See backend work here

Screenshots

Screen.Recording.2025-05-08.at.15.17.34.mov

Arabic

Screenshot 2025-05-08 at 16 13 19

Related Issue

Other

@jnsereko jnsereko changed the title Patient Identifier Sticker should get the sticker from the backend (feat) Patient Identifier Sticker should get the sticker from the backend May 8, 2025
@jnsereko jnsereko marked this pull request as draft May 8, 2025 13:14
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it may not make sense to merge this into the patient-banner-app, but to create a new app that can hold this (and depend on common reports) that exposes an extension that the patient-banner-app can use.

Thoughts?

if (!patient?.id) {
throw new Error('Patient ID not found');
}
return `${window.openmrsBase}/ws/module/commonreports/patientIdSticker?patientUuid=${patient.id}`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So common-reports would now need to be listed as a dependency in the routes.json if we merge this in.

@gracepotma
Copy link
Contributor

I think it may not make sense to merge this into the patient-banner-app, but to create a new app that can hold this (and depend on common reports) that exposes an extension that the patient-banner-app can use.

Thoughts?

I agree @ibacher - especially because I forsee implementations wanting to add a print action button elsewhere throughout the application (such as in patient-management apps like Queues and clerical views, for a fast-print button; or billing for receipts, etc) so couching this within the banner app feels a bit restrictive. Though I get the initial use case :)

@jnsereko jnsereko force-pushed the LIME2-718 branch 2 times, most recently from c4aadcc to 7da2305 Compare May 13, 2025 06:02
@jnsereko jnsereko marked this pull request as ready for review May 27, 2025 08:14
@jnsereko jnsereko requested review from denniskigen and ibacher May 27, 2025 08:15
@jnsereko
Copy link
Contributor Author

cc @pirupius @vasharma05

@denniskigen denniskigen changed the title (feat) Patient Identifier Sticker should get the sticker from the backend (feat) Add label printing app for handling printing concerns Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants