fix/03-4454: Clicking on the Order Basket should not do anything when the order basket is open #2468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnasambu
changed the title
ibacher
reviewed
May 22, 2025
There was a problem hiding this comment.
Maybe it is better to make this more general, i.e., by moving this into the launchWorkspace() function in core and just make it do nothing if the requested workspace is the same as the current workspace.
The tricky bit here is that the order basket uses multiple workspaces, and we want the button to do nothing (other than maybe collapse the workspace) for all of them.
Comment on lines
22
to
25
| onClick={(e) => { | ||
| if (isWorkspaceOpen) { | ||
| e.stopPropagation(); | ||
| } |
There was a problem hiding this comment.
Do we need this kind of guard here? Isn't it enough to just change the handleClick() stuff?
| import { useLaunchWorkspaceRequiringVisit, useOrderBasket } from '@openmrs/esm-patient-common-lib'; | ||
|
|
||
| const OrderBasketActionButton: React.FC = () => { | ||
| const { t } = useTranslation(); | ||
| const { orders } = useOrderBasket(); | ||
| const { activeWorkspace } = useWorkspaceContext(); |
There was a problem hiding this comment.
I don't think this exists? There is a useWorkspaces(), but that may require additional details. I don't think it tells you what workspace is active.
… the order basket is open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the order basket is open
Requirements
Summary
To ensure that clicking the shopping cart icon does nothing when the "order-basket" workspace is already open, I created a function to:
Check if the workspace is open.
Then, wrap the icon in a clickable element that cancels the click event if the workspace is already active.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4454
Other