Skip to content

change setNodeEnv code to avoid warnings when using the Cloudflare adapter #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/open-next/src/adapters/util.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
//TODO: We should probably move all the utils to a separate location

export function setNodeEnv() {
process.env.NODE_ENV = process.env.NODE_ENV ?? "production";
// Note: we create a `processEnv` variable instead of just using `process.env` directly
// because build tools can substitute `process.env.NODE_ENV` on build making
// assignments such as `process.env.NODE_ENV = ...` problematic
const processEnv = process.env;
processEnv.NODE_ENV = process.env.NODE_ENV ?? "production";
}

export function generateUniqueId() {
Expand Down
Loading