Fix valuator's permissions #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 94.33% 94.65% +0.31%
==========================================
Files 66 67 +1
Lines 1413 1516 +103
==========================================
+ Hits 1333 1435 +102
- Misses 80 81 +1
☔ View full report in Codecov by Sentry. |
microstudi
reviewed
Oct 16, 2023
| if current_participatory_space.user_roles(:valuator).where(user: current_user).empty? | ||
| Suggestion.where(suggestable: document).or(Suggestion.where(suggestable: document.sections)) | ||
| else | ||
| valuator_roles = current_participatory_space.user_roles(:valuator).where(user: current_user) |
There was a problem hiding this comment.
We could probaly extract this in a private method and used in the "if" before
|
@microstudi I added tests, did some refactoring. Сould you do the review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.