-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decidim upgrade to 0.28 #124
base: main
Are you sure you want to change the base?
Conversation
antopalidi
commented
Mar 18, 2024
•
edited
Loading
edited
db/migrate/20221115233023_create_decidim_participatory_documents_suggestions.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Vergés <[email protected]>
…ticipatory-documents into upgrade-0.28
Co-authored-by: Ivan Vergés <[email protected]>
@antopalidi remember to update the plugin version to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 93.50% 93.10% -0.40%
==========================================
Files 67 65 -2
Lines 1540 1451 -89
==========================================
- Hits 1440 1351 -89
Misses 100 100 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, but as Decidim 0.28.1 is out, can we make the update (as suggested in the comments) before mergin?
# rubocop:disable Rails/ThreeStateBooleanColumn | ||
t.boolean :answer_is_published, default: false | ||
# rubocop:enable Rails/ThreeStateBooleanColumn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# rubocop:disable Rails/ThreeStateBooleanColumn | |
t.boolean :answer_is_published, default: false | |
# rubocop:enable Rails/ThreeStateBooleanColumn | |
t.boolean :answer_is_published, default: false, null: false |
Instead of the cop, let's just remove the null no?
DECIDIM_VERSION = "0.27.5" | ||
COMPAT_DECIDIM_VERSION = [">= 0.27.0", "< 0.28"].freeze | ||
VERSION = "0.3.0" | ||
DECIDIM_VERSION = "0.28" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DECIDIM_VERSION = "0.28" | |
DECIDIM_VERSION = "0.28.1" |
Let's upgrade to 0.28.1
RSpec/RemoveConst: | ||
Enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this?