Export suggestions as admin #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 94.33% 94.72% +0.38%
==========================================
Files 66 67 +1
Lines 1412 1516 +104
==========================================
+ Hits 1332 1436 +104
Misses 80 80
☔ View full report in Codecov by Sentry. |
microstudi
requested changes
Oct 16, 2023
microstudi
requested changes
Oct 25, 2023
Comment on lines
+230
to
+235
| around do |example| | ||
| original_setting = ActionController::Base.allow_forgery_protection | ||
| ActionController::Base.allow_forgery_protection = true | ||
| example.run | ||
| ActionController::Base.allow_forgery_protection = original_setting | ||
| end |
There was a problem hiding this comment.
Why do we need this?
is not the user clicking on the export button? shoudn't the authenticity_token be present already?
|
|
||
| perform_enqueued_jobs { click_button "Send me my suggestions" } | ||
|
|
||
| expect(page).to have_content("2 suggestions have been successfully exported") |
There was a problem hiding this comment.
Can we check here the content of the email too?
attachment = last_email.attachments.first
Zip::File.open_buffer(attachment.body.raw_source) do |zip_file|
json_file_entry = zip_file.glob("*.json").first
json_content = json_file_entry.get_input_stream.read
json_data = JSON.parse(json_content)
expect(json_data.length).to eq(all_suggestions_count)
end
Co-authored-by: Ivan Vergés <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes stadtluzern/decidim-pdf-consultations#48