(doc) Description of Log4j 1 to Log4j 2 APi migration #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The description of the "Migrate Log4j 1.x to Log4j 2.x" recipe is incorrect. Users might get the false impression that it mitigates the Log4Shell vulnerability. However: - Log4j 1 was **never** affected by Log4Shell. - only Log4j 2 Core was. There are multiple reasons to migrate from Log4j 1, the first one is that the library is unsupported since 2015. Log4Shell mitigation is **not** one of them.
timtebeek
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thanks a lot for pointing that out @ppkarwasz ! We'll see this through as is.
The recipe does bring folks to versions that no longer contain the Log4Shell vulnerability, through our use of version patterns that match the latest minor release.
You're very right in pointing out that the Log4J 1.x branch has nothing to do with that, and it's then best to avoid confusion.
|
However, we do need a recipe that mitigates Log4Shell with a description stating that since, otherwise, people cannot find it in the catalog. Would you be able to create one @timtebeek? I assume it's a subset of Log4j 1 to Log4j 2 migration? |
timtebeek
added a commit
that referenced
this pull request
Jun 6, 2024
As requested on #150 (comment)
timtebeek
added a commit
that referenced
this pull request
Jun 7, 2024
* Create a separate Log4Shell recipe As requested on #150 (comment) * Update log4j.yml to fix Copilot suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
This documentation-only PR changes the description of the "Migrate Log4j 1.x to Log4j 2.x" recipe.
What's your motivation?
The description of the "Migrate Log4j 1.x to Log4j 2.x" recipe is incorrect.
Users might get the false impression that it mitigates the Log4Shell vulnerability. However:
There are multiple reasons to migrate from Log4j 1, the first one is that the library is unsupported since 2015. Log4Shell mitigation is not one of them.