Skip to content

Convert JUL Logger Level arguments to methods #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 15, 2024
Merged

Convert JUL Logger Level arguments to methods #156

merged 4 commits into from
Jun 15, 2024

Conversation

timtebeek
Copy link
Member

Fixes #155

@timtebeek timtebeek self-assigned this Jun 15, 2024
@timtebeek timtebeek mentioned this pull request Jun 15, 2024
Closed
@timtebeek timtebeek added enhancement New feature or request recipe Recipe Requested labels Jun 15, 2024
@timtebeek timtebeek merged commit 45a53b4 into main Jun 15, 2024
2 checks passed
@timtebeek timtebeek deleted the jul-level-argument-to-method branch June 15, 2024 10:00
woj-tek
woj-tek reviewed Jun 15, 2024
View reviewed changes
src/test/java/org/openrewrite/java/logging/jul/LoggerLevelArgumentToMethodTest.java
class Test {
void test(Logger logger, String message) {
logger.log(Level.ALL, message);
logger.log(Level.CONFIG, message);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't logger.log(Level.CONFIG, message); be converted to logger.config(message); for consistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right. Picked up separately with a commit to main

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woj-tek woj-tek woj-tek left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@timtebeek timtebeek

Labels
enhancement New feature or request recipe Recipe Requested
Projects
OpenRewrite
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recipe for migrating from JUL to slf4j? With support for Logger.log(Level,String) calls?
2 participants
@timtebeek @woj-tek