Add StringFormat, MessageFormat, and RemoveUnnecessaryLogLevelGuards SLF4J recipes.#280
Merged
timtebeek merged 6 commits intoopenrewrite:mainfrom Feb 26, 2026
Merged
Conversation
RemoveUnnecessaryLogLevelGuards incorrectly removes guards around
logging calls that use string concatenation (e.g. `"Name: " + name`)
instead of parameterized `{}` placeholders. The guard is necessary
in these cases because concatenation is evaluated eagerly.
Validated at scale against the Default org where Netflix/ribbon had
two false positives in DiscoveryEnabledNIWSServerList and RestClient.
timtebeek
approved these changes
Feb 26, 2026
Member
timtebeek
left a comment
There was a problem hiding this comment.
Nice additions, thanks! I've added some polish mostly to use ListUtils and other ways to minimize the changeset.
This was referenced Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Add three new SLF4J recipes to
Slf4jBestPractices:StringFormatToParameterizedLogging— ReplacesString.format()calls in SLF4J logging statements with parameterized{}placeholders.MessageFormatToParameterizedLogging— ReplacesMessageFormat.format()calls in SLF4J logging statements with parameterized{}placeholders.RemoveUnnecessaryLogLevelGuards— Removesif (logger.isDebugEnabled())guards around SLF4J logging calls when parameterized logging makes them unnecessary.The
StringFormatandMessageFormatrecipes are ordered before the existingParameterizedLoggingrecipe inslf4j.ymlso that format calls are converted to parameterized logging first, beforeParameterizedLogginghandles string concatenation.What's your motivation?
String.format()andMessageFormat.format()defeat the purpose of SLF4J's parameterized logging by eagerly formatting the message regardless of log level. The existingParameterizedLoggingrecipe handles string concatenation but not these cases.Similarly, once logging statements use parameterized
{}placeholders, explicitisDebugEnabled()/isTraceEnabled()guards become unnecessary boilerplate since SLF4J defers argument evaluation.Anything in particular you'd like reviewers to focus on?
RemoveUnnecessaryLogLevelGuardsrecipe only removes guards when all logging calls inside the guard body use parameterized logging (no string concatenation or method calls other than toString()).Anyone you would like to review specifically?
@timtebeek saw these recipes as I was developing them in Liftwizard:
Have you considered any alternatives or workarounds?
I considered splitting this into two PRs and I could still do that if preferred.
Any additional context
Checklist