Skip to content

Add kotlin autoDetect#619

Closed
kunli2 wants to merge 5 commits intomainfrom
kunli/kotlin-autodetect
Closed

Add kotlin autoDetect#619
kunli2 wants to merge 5 commits intomainfrom
kunli/kotlin-autodetect

Conversation

@kunli2
Copy link
Contributor

@kunli2 kunli2 commented Aug 21, 2023

Add Kotlin autoDetect to maven plug-in.

@kunli2 kunli2 requested a review from knutwannheden August 21, 2023 21:58
@kunli2 kunli2 marked this pull request as draft August 22, 2023 00:09
@knutwannheden
Copy link
Contributor

@kunli2 As far as I remember this also requires some corresponding changes in moderne-ast-write. Can you look into that and create a corresponding PR?

@kunli2
Copy link
Contributor Author

kunli2 commented Aug 22, 2023

will postpone this PR until we add Kotlin parsing in the maven plug-in.

@timtebeek timtebeek added the enhancement New feature or request label Aug 31, 2023
@timtebeek
Copy link
Member

Not quite sure what the current status is on this PR, or why we've held off on

Would we want to add the KotlinParser here directly?

Or do we plan to move to the OmniParser in rewrite-polyglot?

@knutwannheden
Copy link
Contributor

@kunli2 Meanwhile I think we have the Kotlin parser integrated in the Maven plugin, so I think this is something we can merge, right?

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 14, 2025
@github-actions github-actions bot closed this Jul 21, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in OpenRewrite Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants