Javascript - removing the notion of scope in variable declarations#5577
Merged
greg-at-moderne merged 5 commits intomainfrom Jun 9, 2025
Merged
Javascript - removing the notion of scope in variable declarations#5577greg-at-moderne merged 5 commits intomainfrom
greg-at-moderne merged 5 commits intomainfrom
Conversation
greg-at-moderne
changed the title
JohannisK
pushed a commit
that referenced
this pull request
Jun 10, 2025
…5577) * Removing the notion of import.scope * Adapting to no notion of import.scope * Adapting to no notion of import.scope * RPC for import.initializer * Removing TODOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Following #5569:
ScopedVariableDeclarations.scopeas let/const/var was already moved to VariableDeclarations.modifierWhat's your motivation?
To meet the design decision of "remove that import scope and instead update the model of JS.Import to cover that case".