Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disable-assimp CLI flag #219

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Add disable-assimp CLI flag #219

merged 4 commits into from
Sep 29, 2023

Conversation

H1rono
Copy link
Contributor

@H1rono H1rono commented Sep 29, 2023

close #218

@H1rono H1rono requested a review from taiki-e September 29, 2023 05:27
taiki-e
taiki-e approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@H1rono H1rono merged commit 9cf51a7 into main Sep 29, 2023
6 checks passed
@H1rono H1rono deleted the h1rono/assimp-flag branch September 29, 2023 06:14
@taiki-e taiki-e mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow switching mesh parser when compiled with assimp feature enabled
2 participants
@H1rono @taiki-e