-
Notifications
You must be signed in to change notification settings - Fork 66
Trace Analytics v2 update - adding in conext views, updating filter, adding services metrics #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…readcrumb Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
…yout Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explorer changes look good to me
Signed-off-by: Shenoy Pratik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't get to read everything but no concerns so far. i'll do some testing later and report if any issues
@@ -83,6 +91,9 @@ export function ServiceMap({ | |||
}, | |||
]; | |||
|
|||
const [selectedNodeDetails, setSelectedNodeDetails] = useState<ServiceNodeDetails | null>(null); | |||
const graphContainerRef = React.useRef(null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from another approach I was trying to solve onClick handler
for the node. Ended up just using the selectedNodeDetails
. So, I'll remove this one.
setGlobalQuery(newQuery); | ||
props.refresh(undefined, newQuery); | ||
}, | ||
})); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO for future, this can probably just be a ref from parent and attached to EuiFieldSearch
, to simplify the logic and reduce re-renders
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1883-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2a446bb990a92c071012668eacc581c629a88fe7
# Push it to GitHub
git push --set-upstream origin backport/backport-1883-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
…adding services metrics (opensearch-project#1883) * move trace group to traces, fix service filter bug, fix traces view breadcrumb Signed-off-by: Shenoy Pratik <[email protected]> * add support for attribute filters and group services Signed-off-by: Shenoy Pratik <[email protected]> * adding support for trends and jump to logs explorer Signed-off-by: Shenoy Pratik <[email protected]> * style updates to trends plots Signed-off-by: Shenoy Pratik <[email protected]> * update dependency based service map, update back button in service flyout Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshots Signed-off-by: Shenoy Pratik <[email protected]> * cleanup unused code Signed-off-by: Shenoy Pratik <[email protected]> * revert viz background change Signed-off-by: Shenoy Pratik <[email protected]> * update app analytics snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update coreRef test mock with chrome Signed-off-by: Shenoy Pratik <[email protected]> * minor bug fixes and jaeger support Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 2a446bb)
…dating filter, … (#1885) * Trace Analytics v2 update - adding in conext views, updating filter, adding services metrics (#1883) * move trace group to traces, fix service filter bug, fix traces view breadcrumb Signed-off-by: Shenoy Pratik <[email protected]> * add support for attribute filters and group services Signed-off-by: Shenoy Pratik <[email protected]> * adding support for trends and jump to logs explorer Signed-off-by: Shenoy Pratik <[email protected]> * style updates to trends plots Signed-off-by: Shenoy Pratik <[email protected]> * update dependency based service map, update back button in service flyout Signed-off-by: Shenoy Pratik <[email protected]> * updated snapshots Signed-off-by: Shenoy Pratik <[email protected]> * cleanup unused code Signed-off-by: Shenoy Pratik <[email protected]> * revert viz background change Signed-off-by: Shenoy Pratik <[email protected]> * update app analytics snapshots Signed-off-by: Shenoy Pratik <[email protected]> * update coreRef test mock with chrome Signed-off-by: Shenoy Pratik <[email protected]> * minor bug fixes and jaeger support Signed-off-by: Shenoy Pratik <[email protected]> * update tests Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit 2a446bb) * update lodash import Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]>
Description
Below are the UX changes done for trace analytics v2, the PR is mainly restricted to changes in
public/components/trace_analytics/
with minor state pass update in explorer. Tried to fix a lot of lint issues, still some of them are pending. Will create another PR for updating cypress and adding more jest tests for new components. Below is the list of features added in this PR:Major files changes that need to be reviewed are the ones below, the other files are changes for theming, minor additions and test/lint updates
OR
clauseIssues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.