Skip to content

Rename Flint instances to S3 Glue #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jun 10, 2024

Description

At the request of management: Flint is a code-name and we should rename public-facing instances of flint in the codebase to "S3 Glue". I tried to replace every occurrence that's in some sort of display name that doesn't need to exist, plus all of the labels. I've left some more interconnected instances like asset/workflow keys and filenames, because getting all the wiring right there is likely to be error-prone.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@YANG-DB YANG-DB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u plz repeat the process for the corresponding catalog assets ?

@Swiddis Swiddis merged commit 81dd71c into opensearch-project:main Jun 11, 2024
14 of 19 checks passed
@Swiddis Swiddis deleted the flint-to-glue branch June 11, 2024 17:20
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 11, 2024
Signed-off-by: Simeon Widdis <[email protected]>
(cherry picked from commit 81dd71c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x integrations Used to denote items related to the Integrations project maintenance v2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants