Traces table fix for invalid date #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
joshuali925
approved these changes
Apr 3, 2025
ps48
reviewed
Apr 3, 2025
| @@ -366,6 +365,6 @@ describe('Testing traces Custom source', () => { | |||
|
|
|||
| cy.get('a.euiLink.euiLink--primary').first().click(); | |||
| cy.get('[data-test-subj="globalLoadingIndicator"]').should('not.exist'); | |||
| cy.get('.overview-content').should('contain.text', 'be0a3dceda2ecf601fd2e476fef3ee07'); | |||
| cy.get('.overview-content').should('contain.text', 'd5bc99166e521eec173bcb7f9b0d3c43'); | |||
There was a problem hiding this comment.
The date was previously invalid. With the actual date displayed, the default sorting added in changes the order and this test was clicking the first link which is now d5bc99166e521eec173bcb7f9b0d3c43.
ps48
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the query for traces was dependent on a trace group being present to display the date. This change adds a fallback so that if the trace does not have a group we still display the date it was last updated.
This also removes the default 0 value that was displayed for duration in these cases that was misleading and instead shows "-" indicating the trace group is absent.
These changes don't impact the displayed metrics or calculations, it just improves the user's experience and provides additional clarity.
Before:
After:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.