Skip to content

Cypress - Config fix #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 11, 2025
Merged

Cypress - Config fix #2408

merged 28 commits into from
Apr 11, 2025

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Apr 8, 2025

Description

[Cypress] Upgrade cypress version to ^13.6.0 from #2405
Causes the following error:
Screenshot 2025-04-08 at 1 40 27 PM
In order to fix this crashing, following guidance from cypress-io/cypress#27415 (comment)
In addition to enable experimental memory and lowering test kept in memory to 0 and disabling testIsolation.
These changes allow the test to run without crashing and are all required currently for the CI's to run successfully.

  1. Fix errors where { timeout: COMMAND_TIMEOUT_LONG } was undefined as it had been removed from a previous PR: Update notebooks snapshots and cypress #1367. Previous version of Cypress did not crash with this undefined value.
Screenshot 2025-04-09 at 9 32 35 AM
  1. Adjust test to account for testIsolation being set to false, this means a lot of the test needed manual clean up to clear filters, or text fields as this was previously handled by the test isolation.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@TackAdam TackAdam added the bug Something isn't working label Apr 8, 2025
Adam Tackett added 2 commits April 8, 2025 13:48
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
@ps48
Copy link
Member

ps48 commented Apr 8, 2025

@TackAdam maybe this can help: cypress-io/cypress#27415 (comment)

Adam Tackett added 8 commits April 8, 2025 14:02
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.01%. Comparing base (5cfbba1) to head (17a09a5).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2408      +/-   ##
==========================================
- Coverage   56.53%   56.01%   -0.52%     
==========================================
  Files         393      398       +5     
  Lines       15574    16072     +498     
  Branches     4284     4501     +217     
==========================================
+ Hits         8804     9002     +198     
- Misses       6705     6998     +293     
- Partials       65       72       +7     
Flag Coverage Δ
dashboards-observability 56.01% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Adam Tackett and others added 11 commits April 9, 2025 09:32
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
fix
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Adam Tackett added 4 commits April 10, 2025 14:40
fix
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Signed-off-by: Adam Tackett <[email protected]>
Adam Tackett added 2 commits April 11, 2025 09:48
@TackAdam TackAdam marked this pull request as ready for review April 11, 2025 19:19
Copy link
Collaborator

@paulstn paulstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulstn
Copy link
Collaborator

paulstn commented Apr 11, 2025

Would this need any backports?
Also, if we backport into 2.x, we should make sure there are no issues this config change might cause

@TackAdam
Copy link
Collaborator Author

Would this need any backports? Also, if we backport into 2.x, we should make sure there are no issues this config change might cause

We didn't back-port the update to cypress: #2405
So shouldn't be necessary.

@TackAdam TackAdam merged commit 4c7c403 into opensearch-project:main Apr 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants