Added array support for ndjson inputcodec #5875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivagnanam-arumugam
requested review from
sb2k16,
chenqi0805,
engechas,
san81,
srikanthjg,
graytaylor0,
dinujoh,
kkondaka,
KarstenSchnitter,
dlvenable and
oeyh
as code owners
KarstenSchnitter
previously approved these changes
Jul 7, 2025
dlvenable
requested changes
Jul 14, 2025
There was a problem hiding this comment.
Thank you @sivagnanam-arumugam for this contribution!
The DCO check is failing: https://github.com/opensearch-project/data-prepper/pull/5875/checks?check_run_id=45354977732
| void parse_with_array_of_objects_asserts_number_of_objects() throws IOException { | ||
| final NdjsonInputCodec objectUnderTest = createObjectUnderTest(); | ||
|
|
||
| final String jsonArray = "[{\"key1\":\"value1\"},{\"key2\":\"value2\"}]"; |
There was a problem hiding this comment.
Does this change support reading multiple arrays from different lines?
[{\"key1\":\"value1\"},{\"key2\":\"value2\"}]
[{\"key3\":\"value3\"},{\"key4\":\"value4\"}]
If so, we should test this too.
There was a problem hiding this comment.
Added multiple array support and added unit test cases.
Added signed-off-by commit message.
Signed-off-by: sivagnanam-arumugam <[email protected]>
Added test cases for multiple array support Signed-off-by: sivagnanam-arumugam <[email protected]>
sivagnanam-arumugam
force-pushed
the
array-support-ndjson-inputcodec
branch
from
27c9f6e to
366f512
Compare
dlvenable
reviewed
Jul 15, 2025
There was a problem hiding this comment.
Thank you @sivagnanam-arumugam for this contribution and follow up changes!
@KarstenSchnitter , Would you like to take another look?
KarstenSchnitter
approved these changes
Jul 15, 2025
dlvenable
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Array support for ndjson input codec,
Array line is handled in logstash json_lines codec, So added the support to data prepper.
Issues Resolved
Resolves #5874
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.