Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sample templates for text to visualziation #936

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Oct 28, 2024

Description

Add sample templates for text to visualization.
These templates will be used by OpenSearch-Dashboards plugin dashboards-assistant to setup text to visualization feature. Documentation could be found here: https://opensearch.org/docs/latest/dashboards/dashboards-assistant/text-to-visualization/

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added the backport 2.x backport PRs to 2.x branch label Oct 28, 2024
@ruanyl ruanyl marked this pull request as ready for review November 11, 2024 03:42
@ruanyl
Copy link
Member Author

ruanyl commented Nov 11, 2024

@dbwiddis @owaiskazi19 Could you take a look the PR please?

@dbwiddis
Copy link
Member

dbwiddis commented Nov 11, 2024

@ruanyl Will do. I saw it earlier but it was in draft until just now.

Note the spotless check is failing (looks like trailing whitespace). Please run ./gradlew spotlessApply and commit the difference. Also add a section to the 2.x documentation on the change log.

@ruanyl ruanyl force-pushed the add-template-for-text-to-visualziation branch from 4649941 to ba05e6a Compare November 11, 2024 04:51
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending spotless fix

@owaiskazi19
Copy link
Member

@ruanyl can you also some description about the use case for this template in the PR?

Signed-off-by: Yulong Ruan <[email protected]>
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.57%. Comparing base (9b9ebb2) to head (de6cae1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #936      +/-   ##
============================================
- Coverage     78.07%   77.57%   -0.50%     
+ Complexity      996      993       -3     
============================================
  Files            99       99              
  Lines          4625     4714      +89     
  Branches        431      431              
============================================
+ Hits           3611     3657      +46     
- Misses          834      877      +43     
  Partials        180      180              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuye-aws
Copy link
Member

@ruanyl can you also some description about the use case for this template in the PR?

Description updated. Can u review again?

@yuye-aws
Copy link
Member

@ruanyl Is there going to be a PR adding t2vega_agent (without instruction)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport PRs to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants