-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sample templates for text to visualziation #936
base: main
Are you sure you want to change the base?
add sample templates for text to visualziation #936
Conversation
@dbwiddis @owaiskazi19 Could you take a look the PR please? |
@ruanyl Will do. I saw it earlier but it was in draft until just now. Note the spotless check is failing (looks like trailing whitespace). Please run |
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
Signed-off-by: Yulong Ruan <[email protected]>
4649941
to
ba05e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending spotless fix
@ruanyl can you also some description about the use case for this template in the PR? |
Signed-off-by: Yulong Ruan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
============================================
- Coverage 78.07% 77.57% -0.50%
+ Complexity 996 993 -3
============================================
Files 99 99
Lines 4625 4714 +89
Branches 431 431
============================================
+ Hits 3611 3657 +46
- Misses 834 877 +43
Partials 180 180 ☔ View full report in Codecov by Sentry. |
Description updated. Can u review again? |
@ruanyl Is there going to be a PR adding |
Description
Add sample templates for text to visualization.
These templates will be used by OpenSearch-Dashboards plugin dashboards-assistant to setup text to visualization feature. Documentation could be found here: https://opensearch.org/docs/latest/dashboards/dashboards-assistant/text-to-visualization/
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.