Register admin UI as AI models in data administration use case #337
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
reviewed
Jun 26, 2024
public/plugin.ts
Outdated
| @@ -48,6 +55,18 @@ export class MlCommonsPluginPlugin | |||
| }, | |||
| }); | |||
|
|
|||
| core.chrome.addNavLinksToGroup(DEFAULT_NAV_GROUPS.dataAdministration, [ | |||
There was a problem hiding this comment.
Do you need to check the feature flag here?
There was a problem hiding this comment.
Never mind, this is not application register
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
ruanyl
reviewed
Jul 9, 2024
public/plugin.ts
Outdated
| category: { | ||
| id: 'ai-model', | ||
| label: i18n.translate('MLCommonsDashboards.AIModels.Category', { | ||
| defaultMessage: 'ai models', |
There was a problem hiding this comment.
Should the message say:
Suggested change
| defaultMessage: 'ai models', | |
| defaultMessage: 'AI models', |
There was a problem hiding this comment.
It was using "ai models" in the UX design.
@lauralexis Could you help me take a look? Shall we change to AI models?
There was a problem hiding this comment.
UX design updated, already change to AI models
ruanyl
approved these changes
Jul 9, 2024
raintygao
approved these changes
Jul 9, 2024
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
changed the title
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
* Register admin UI as ai models in data administration use case Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix addNavLinksToGroup not found in chrome service Signed-off-by: Lin Wang <wonglam@amazon.com> * Update nav link text Signed-off-by: Lin Wang <wonglam@amazon.com> * Change text to AI models Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 83b3a2d)
wanglam
added a commit
that referenced
this pull request
Jul 12, 2024
…#339) * Register admin UI as ai models in data administration use case Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix addNavLinksToGroup not found in chrome service Signed-off-by: Lin Wang <wonglam@amazon.com> * Update nav link text Signed-off-by: Lin Wang <wonglam@amazon.com> * Change text to AI models Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 83b3a2d) Co-authored-by: Lin Wang <wonglam@amazon.com>
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Register to data administration use case based OSD main branch.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.