Add semantic field mapper. #1225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzhangam
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
github-actions
bot
added
Enhancements
bzhangam
commented
Mar 11, 2025
bzhangam
commented
Mar 11, 2025
junqiu-lei
reviewed
Mar 11, 2025
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
will-hwang
reviewed
Mar 11, 2025
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Show resolved
Hide resolved
...ain/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeFactory.java
Outdated
Show resolved
Hide resolved
.../java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeParameters.java
Outdated
Show resolved
Hide resolved
q-andy
reviewed
Mar 13, 2025
src/main/java/org/opensearch/neuralsearch/constants/SemanticFieldConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Outdated
Show resolved
Hide resolved
...ain/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldType.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticFieldTypeTests.java
Outdated
Show resolved
Hide resolved
...java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticStringFieldTypeTests.java
Outdated
Show resolved
Hide resolved
...main/java/org/opensearch/neuralsearch/mapper/semanticFieldTypes/SemanticNumberFieldType.java
Outdated
Show resolved
Hide resolved
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1225 +/- ##
============================================
- Coverage 80.63% 0 -80.64%
============================================
Files 127 0 -127
Lines 5722 0 -5722
Branches 932 0 -932
============================================
- Hits 4614 0 -4614
+ Misses 753 0 -753
+ Partials 355 0 -355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
junqiu-lei
reviewed
Apr 16, 2025
src/main/java/org/opensearch/neuralsearch/mapper/dto/SemanticParameters.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/SemanticFieldMapper.java
Outdated
Show resolved
Hide resolved
bzhangam
force-pushed
the
main
branch
2 times, most recently
from
77df55c to
1926bc4
Compare
junqiu-lei
approved these changes
Apr 17, 2025
Comment on lines
+15
to
+21
| public static final String MODEL_ID = "model_id"; | ||
|
|
||
| /** | ||
| * Name of the search model id parameter. We use this key to define the id of the ML model that we will use to | ||
| * inference the query text during the search. If this parameter is not defined we will use the model_id instead. | ||
| */ | ||
| public static final String SEARCH_MODEL_ID = "search_model_id"; |
There was a problem hiding this comment.
Why we need 2 model_id fields? Can we only keep 1 model_id field? Why we need separate model_ids for inferencing for index and search?
There was a problem hiding this comment.
It's needed to support the sparse model use case.
| @@ -214,17 +225,6 @@ public Map<String, Processor.Factory> getProcessors(Processor.Parameters paramet | |||
|
|
|||
| @Override | |||
| public Optional<QueryPhaseSearcher> getQueryPhaseSearcher() { | |||
| // we're using "is_disabled" flag as there are no proper implementation of FeatureFlags.isDisabled(). Both | |||
There was a problem hiding this comment.
why removing NEURAL_SEARCH_HYBRID_SEARCH_DISABLED and related lines is included in this cr?
bzhangam
force-pushed
the
main
branch
3 times, most recently
from
c7890a2 to
3147dcb
Compare
yizheliu-amazon
approved these changes
Apr 17, 2025
Signed-off-by: Bo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add semantic field mapper to support the semantic field type.
Also remove the incorrect FF NEURAL_SEARCH_HYBRID_SEARCH_DISABLED.
Related Issues
Resolves #[803]
Resolves part of the issue #1226
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.