Support configuring the chunking strategies through the semantic field. #1446
+767
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzhangam
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
heemin32
reviewed
Jul 14, 2025
src/main/java/org/opensearch/neuralsearch/mapper/dto/ChunkingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/dto/ChunkingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Chunker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/ChunkerFactory.java
Outdated
Show resolved
Hide resolved
bzhangam
force-pushed
the
chunkingconfig
branch
2 times, most recently
from
1b8772a to
85d9bd4
Compare
heemin32
reviewed
Jul 15, 2025
src/main/java/org/opensearch/neuralsearch/mapper/dto/ChunkingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/dto/ChunkingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/mapper/dto/ChunkingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Chunker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/ChunkerFactory.java
Outdated
Show resolved
Hide resolved
bzhangam
force-pushed
the
chunkingconfig
branch
8 times, most recently
from
a39c5ad to
55526d3
Compare
heemin32
approved these changes
Jul 15, 2025
junqiu-lei
reviewed
Jul 16, 2025
src/main/java/org/opensearch/neuralsearch/processor/dto/SemanticFieldInfo.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/dto/SemanticFieldInfo.java
Show resolved
Hide resolved
yuye-aws
reviewed
Jul 16, 2025
src/main/java/org/opensearch/neuralsearch/mapper/dto/ChunkingConfig.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Validator.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Chunker.java
Outdated
Show resolved
Hide resolved
yuye-aws
reviewed
Jul 17, 2025
src/main/java/org/opensearch/neuralsearch/processor/chunker/Chunker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Chunker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Parser.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Validator.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/chunker/Chunker.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bo Zhang <[email protected]>
yuye-aws
reviewed
Jul 21, 2025
| return; | ||
| } | ||
| if (chunkingConfig instanceof List<?>) { | ||
| List<Map<String, Object>> configList = (List<Map<String, Object>>) chunkingConfig; |
There was a problem hiding this comment.
Could there be non-map elements in the list
There was a problem hiding this comment.
No. The field config of the semantic field is validated when we create it in the index mapping to ensure this.
|
@bzhangam No other comments. Will approve this PR once the conflicts are resolved. |
Signed-off-by: Bo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support configuring the chunking strategies through the semantic field.
Related Issues
Resolves #1354
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.