Rebase new commits from opendistro repo #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tibility. Signed-off-by: Jeff Wright <[email protected]>
…ds compatibility." This reverts commit 0c09b5fa3c44ef0957884b0ec3cd1cf6e216ef5d.
Renamed 'traceGroup' to 'traceGroupFields' to support backwards compa…
Fixed getTracesQuery, was returning 0 unexpectedly.
* Add null check for service map query * Loop through filters when switching percentile filters * Add check before changing percentile filter
* Revert "Add null check for service map, fix percentile filter (#35)" This reverts commit 126c3dbd7e25edd33f6b26aa842ae0fc4167e73a. * Revert "Merge pull request #34 from wrijeff/main" This reverts commit 66a9dcc9bddd7c8dbb6955e1472448e4ed9bd222, reversing changes made to 1cfd7b00227be5bd9cc2d2213297e66f0a213dc8. * Revert "Merge pull request #33 from wrijeff/main" This reverts commit 1cfd7b00227be5bd9cc2d2213297e66f0a213dc8, reversing changes made to e9141628e96c2a80cd3123daf320275b51aad243. * pick: Merge pull request #34 from wrijeff/main Fixed getTracesQuery, was returning 0 unexpectedly. * Add null check for service map, fix percentile filter (#35) * Add null check for service map query * Loop through filters when switching percentile filters * Add check before changing percentile filter * Change to traceGroup Co-authored-by: Jeff Wright <[email protected]>
|
@joshuali925: I've pulled down these changes and am testing with the OpenSearch/Dashboards built artifacts, but I'm still seeing |
@wrijeff I'm not seeing errors on my end. Which branch are you using? this PR branch ( |
wrijeff
approved these changes
Apr 23, 2021
joshuali925
added a commit
that referenced
this pull request
Sep 1, 2021
* Bump to 7.10 * Add github actions * Refactor * Add release notes for ODFE 1.12 * Use env in github actions * Remove target in plugin helpers config * Update readme * Add doc link
joshuali925
added a commit
to joshuali925/observability
that referenced
this pull request
Sep 8, 2021
shankha-das
pushed a commit
to shankha-das/observability
that referenced
this pull request
Jun 24, 2022
…ew-data-config-panel-ui-787 Feature/new data config panel UI 787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cherry picked:
opendistro-for-elasticsearch/trace-analytics#33
opendistro-for-elasticsearch/trace-analytics#34
opendistro-for-elasticsearch/trace-analytics#35
opendistro-for-elasticsearch/trace-analytics#37
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.