Added jenkins job for running release notes generation using LLM workflow. #5669
Conversation
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]>
rishabh6788
requested review from
peterzhuamazon,
gaiksaya and
zelinh
as code owners
rishabh6788
requested review from
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Signed-off-by: Rishabh Singh <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5669 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 404 404
Lines 18372 18372
=======================================
Hits 17724 17724
Misses 648 648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| name: 'INPUT_MANIFEST', | ||
| description: 'Release version number to fetch input manifest path', |
There was a problem hiding this comment.
Description and parameters seems to be mismatched. Let's just take version number from the user.
There was a problem hiding this comment.
Would keep it as manifest and fix description, as taking in version will mean I need to process OS and OSD in the same run, spawning ~50 agents in a single run. I want to be flexible to be able to process one product at a time.
There was a problem hiding this comment.
So we will be running this per manifest?
| name: 'MODEL_ID', | ||
| description: 'AWS Bedrock model id to use, defaults to Anthropic Claude 3.7v2', | ||
| trim: true |
There was a problem hiding this comment.
Do we need to add default value here?
There was a problem hiding this comment.
There is already one in python code.
| def currentIndex = component_index | ||
| def currentWaitSeconds = wait_seconds | ||
|
|
||
| if (!(currentComponent in ['notifications-core', 'functionalTestDashboards'])) { |
There was a problem hiding this comment.
Add dashboards core too? We can remove from python part and add here.
| } | ||
| println("Filename is ${filename}") | ||
| println("Component object: ${componentObj.name}, ${componentObj.ref}, ${componentObj.repository}") | ||
| echo "Current workspace is $WORKSPACE}" |
There was a problem hiding this comment.
Debug statement or is it required?
| git remote set-url origin "https://opensearch-ci:${GITHUB_TOKEN}@github.com/opensearch-project/\$REPO_NAME" | ||
| git config user.email "[email protected]" | ||
| git config user.name "opensearch-ci" | ||
| git checkout -b release/release-notes-${version} |
There was a problem hiding this comment.
I dont think its a good idea to create new branch for each version. They would be kept lingering. How about always push to releaseNotes branch? Hard reset to base branch everytime and then proceed?
We do the same for update-manifest and create-pull-request which is for version increments. https://github.com/opensearch-project/opensearch-build/blob/main/.github/workflows/os-increment-plugin-versions.yml#L161
There was a problem hiding this comment.
Assuming this workflow has to be run once for every release, it makes sense.
| throw new Exception("Error running workflow for component ${currentComponent}", e) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Add a postCleanUp within parallel stages as well? Example: https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/opensearch/integ-test.jenkinsfile#L260
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
Co-authored-by: Sayali Gaikawad <[email protected]> Signed-off-by: Rishabh Singh <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]> Signed-off-by: Rishabh Singh <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]> Signed-off-by: Rishabh Singh <[email protected]>
| binding.setVariable('INPUT_MANIFEST', 'tests/jenkins/data/opensearch-2.2.0.yml') | ||
| binding.setVariable('GITHUB_USER', "GITHUB_USER") | ||
| binding.setVariable('GITHUB_TOKEN', "GITHUB_TOKEN") | ||
| //binding.setVariable('COMPONENTS', 'OpenSearch') |
Signed-off-by: Rishabh Singh <[email protected]>
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
Description
Added jenkins job for running release notes generation using LLM workflow.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.