-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize requests to json #694
base: main
Are you sure you want to change the base?
Serialize requests to json #694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with some documentation in USER_GUIDE or related this could be good enough.
.build(); | ||
|
||
String json = JsonpUtils.toJson(indexRequest); | ||
System.out.println(json); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of print outs.
+1. Some documentation on how to use |
@Tamir-Schwarz Want to finish this? |
Hi @Tamir-Schwarz and @dblock , first of thanks for the contribution, all services of my organization are migrating from the High Level Rest Client to Java Client and very much like these kind of enhancements to be implemented, as they provide a clean code convenience to new clients.
|
@Jai2305 These look very reasonable. Want to open another PR with your suggestions? |
@dblock thanks for a quick response, I am on it. |
link to issue
#588
actually used the code of @dblock - thank you very much!
original example
https://github.com/dblock/opensearch-java-client-demo/blob/to-json/src/main/java/Example.java#L34
=========
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.